Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React from 372ec00c-20241209 to 7eb8234f-20241218 #74101

Closed

Conversation

vercel-release-bot
Copy link
Collaborator

@vercel-release-bot vercel-release-bot commented Dec 18, 2024

Notable changes we had to make:

diff facebook/react@372ec00c...7eb8234f

React upstream changes

@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Failing test suites

Commit: 35ffdbf

pnpm test test/integration/app-dir-export/test/start.test.ts

  • app dir - with output export (next start) > production mode > should warn during next start with output standalone
Expand output

● app dir - with output export (next start) › production mode › should warn during next start with output standalone

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  46 |
  47 |       // TODO: Move this test to test/production to run in isolation.
> 48 |       ;(process.env.TURBOPACK_BUILD ? it.skip : it)(
     |                                                  ^
  49 |         'should warn during next start with output standalone',
  50 |         async () => {
  51 |           nextConfig.replace(`output: 'export'`, `output: 'standalone'`)

  at integration/app-dir-export/test/start.test.ts:48:50
  at integration/app-dir-export/test/start.test.ts:21:56
  at Object.describe (integration/app-dir-export/test/start.test.ts:20:1)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/app-css/index.test.ts (PPR)

  • app dir - css > Suspensey CSS > should suspend on CSS imports if its slow on client navigation
Expand output

● app dir - css › Suspensey CSS › should suspend on CSS imports if its slow on client navigation

TIMED OUT: /background = rgb\(255, 255, 0\)/

undefined

undefined

  731 |
  732 |   if (hardError) {
> 733 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  734 |   }
  735 |   return false
  736 | }

  at check (lib/next-test-utils.ts:733:11)
  at Object.<anonymous> (e2e/app-dir/app-css/index.test.ts:890:9)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-start test/e2e/app-dir/next-dynamic-css/next-dynamic-css.test.ts (PPR)

  • next-dynamic-css > should have correct order of styles on next/dynamic loaded component
Expand output

● next-dynamic-css › should have correct order of styles on next/dynamic loaded component

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#component')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/hydration-error.test.ts

  • Error overlay for hydration errors in App router > should collapse and uncollapse properly when there are many frames
Expand output

● Error overlay for hydration errors in App router › should collapse and uncollapse properly when there are many frames

expect(received).toBe(expected) // Object.is equality

Expected: 4
Received: NaN

  788 |
  789 |     retry(async () => {
> 790 |       expect(await getRedboxTotalErrorCount(browser)).toBe(4)
      |                                                       ^
  791 |     })
  792 |
  793 |     const description = await session.getRedboxDescription()

  at toBe (development/acceptance-app/hydration-error.test.ts:790:55)
  at retry (lib/next-test-utils.ts:806:14)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
buildDuration 29.4s 26.8s N/A
buildDurationCached 24.7s 23.5s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +25.5 kB
nextStartRea..uration (ms) 763ms 778ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
middleware-b..fest.js gzip 668 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 356 kB 358 kB ⚠️ +2.23 kB
app-page-exp..prod.js gzip 129 kB 128 kB N/A
app-page-tur..prod.js gzip 142 kB 141 kB N/A
app-page-tur..prod.js gzip 137 kB 137 kB ⚠️ +352 B
app-page.run...dev.js gzip 347 kB 347 kB ⚠️ +511 B
app-page.run..prod.js gzip 125 kB 125 kB ⚠️ +135 B
app-route-ex...dev.js gzip 37.5 kB 37.4 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.3 kB 25.3 kB N/A
app-route.ru...dev.js gzip 39.1 kB 39.1 kB N/A
app-route.ru..prod.js gzip 25.3 kB 25.3 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 1.07 MB 1.07 MB ⚠️ +3.23 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-7eb8234f-20241218 Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +378 B
index.pack gzip 74.8 kB 74.6 kB N/A
Overall change 2.08 MB 2.08 MB ⚠️ +378 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for bccd1874-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js
failed to diff
Commit: 35ffdbf

@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-7eb8234f-20241218 branch from 76ed2d2 to 1c252ea Compare December 18, 2024 22:25
Copy link
Member

eps1lon commented Dec 18, 2024

Copy link

socket-security bot commented Dec 18, 2024

@ijjk ijjk added the tests label Dec 18, 2024
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-7eb8234f-20241218 branch from 5092ac7 to b9363cf Compare December 18, 2024 22:50
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-7eb8234f-20241218 branch from b9363cf to 35ffdbf Compare December 18, 2024 23:07
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by passive effects not firing after a navigation to a Client Component

@eps1lon
Copy link
Member

eps1lon commented Dec 19, 2024

Blocked on facebook/react#31857

@eps1lon eps1lon closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants