[Flight] Fix double-incremented pending chunks counter #31833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before calling `emitTimingChunk` inside of `forwardDebugInfo`, we must not increment `request.pendingChunks`, as this is already done inside of the `emitTimingChunk` function. I don't have a unit test for this, but manually verified that this fixes the hanging responses in vercel/next.js#73804.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 2bd1c75...b8b2d61 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gnoff
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
We should probably add check validation in dev if you ever go less than 0. This won’t protect us from this particular issue because the chunk counter would never hit zero but it could protect us from the opposite where too few were tracked. It also won’t help in prod but it’s basically free to highlight this one obviously buggy case
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before calling
emitTimingChunkinside offorwardDebugInfo, we must not incrementrequest.pendingChunks, as this is already done inside of theemitTimingChunkfunction.I don't have a unit test for this, but manually verified that this fixes the hanging responses in vercel/next.js#73804.