Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flags] Delete enableSuspenseAvoidThisFallbackFizz #31779

Merged
merged 2 commits into from
Dec 14, 2024
Merged

[flags] Delete enableSuspenseAvoidThisFallbackFizz #31779

merged 2 commits into from
Dec 14, 2024

Conversation

rickhanlonii
Copy link
Member

We're not shipping enableSuspenseAvoidThisFallback and the fizz flag is already off so we can delete it.

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 5:44pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 14, 2024
@react-sizebot
Copy link

react-sizebot commented Dec 14, 2024 •
edited
Loading

Comparing: 0d67cc0...5570e82

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.72 kB 510.72 kB = 91.48 kB 91.48 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.66 kB 515.66 kB = 92.19 kB 92.19 kB
facebook-www/ReactDOM-prod.classic.js = 595.04 kB 595.04 kB = 105.00 kB 105.00 kB
facebook-www/ReactDOM-prod.modern.js = 585.31 kB 585.31 kB = 103.44 kB 103.44 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7b30a5e

@rickhanlonii rickhanlonii merged commit 9e2c233 into facebook:main Dec 14, 2024
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/rm-ff-avoid-fizz branch December 14, 2024 18:05
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 14, 2024
@pull
[flags] Delete enableSuspenseAvoidThisFallbackFizz (facebook#31779)
2a82f49 
We're not shipping `enableSuspenseAvoidThisFallback` and the fizz flag
is already off so we can delete it.

DiffTrain build for [9e2c233](facebook@9e2c233)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 14, 2024
@pull
[flags] Delete enableSuspenseAvoidThisFallbackFizz (facebook#31779)
d42f100 
We're not shipping `enableSuspenseAvoidThisFallback` and the fizz flag
is already off so we can delete it.

DiffTrain build for [9e2c233](facebook@9e2c233)
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @sebmarkbage @facebook-github-bot