Refactor how composite type changes work, fix memory leak in ReactMount caching #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebmarkbage A nice bug fix and some small steps towards not using hierarchical IDs. This should let us try out createElement again. |
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Sep 27, 2015
This reduces our reliance on hierarchical IDs. If facebook#4983 merges, this can look at `._nativeNode` when present.
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Sep 28, 2015
This reduces our reliance on hierarchical IDs. If facebook#4983 merges, this can look at `._nativeNode` when present.
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Sep 28, 2015
This reduces our reliance on hierarchical IDs. If facebook#4983 merges, this can look at `._nativeNode` when present.
| @@ -164,10 +175,11 @@ function setID(node, id) { | |||
| * @internal | |||
| */ | |||
| function getNode(id) { | |||
| if (!nodeCache.hasOwnProperty(id) || !isValid(nodeCache[id], id)) { | |||
| nodeCache[id] = ReactMount.findReactNodeByID(id); | |||
| if (nodeCache.hasOwnProperty(id)) { | |||
There was a problem hiding this comment.
Maybe:
var node = getNodeIfCached(id);
if(node) return node;
else return nodeCache[id] = ReactMount.findReactNodeByID(id);
At the very least that saves an object lookup (object lookups are surprisingly expensive in javascript). It also reads a little better IMO.
There was a problem hiding this comment.
Yeah sure. I was mostly keeping it how it was.
|
Squash and ship! (at least, I have no objection :) ) |
|
Too much for 0.14 unless it fixes a new regression. |
|
Yeah, wasn't going to do it in 0.14. Also was planning to leave the commits separate since they're separate things. |
This was referenced Oct 2, 2015
Before, if you had ``` container = <div data-reactid=".0"><div data-reactid=".0.0" /></div>; ``` and did `ReactDOM.render(<span />, container)` you would get ``` <div data-reactid=".0"><span data-reactid=".0" /></div>; ``` (along with a warning not to replace React-rendered children with a new tree like that). But that makes no sense -- the span should have a new index, not truncate the ID of the old child it's replacing. (Now tests pass again with useCreateElement on; before they threw a "valid but unequal" on our test for this warning.)
This is probably slightly slower for unmounts in the case that no updates were ever performed, but caching the node on the instance should make updates faster. In any case, the more important consequence of this change is that we can fix the current memory leak that happens when swapping composite types.
With this change, all unmounted components should be properly purged from ReactMount's cache.
It never really made sense for us to have "invalid" nodes in the cache -- when we unmount things, we should always remove them from the cache properly. Now that swapping composite types doesn't repopulate the cache, we should be okay to now assume that everything in the cache is good.
sophiebits
added a commit
that referenced
this pull request
Oct 7, 2015
Refactor how composite type changes work, fix memory leak in ReactMount caching
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Oct 7, 2015
This reduces our reliance on hierarchical IDs. If facebook#4983 merges, this can look at `._nativeNode` when present.
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Oct 7, 2015
This reduces our reliance on hierarchical IDs. If facebook#4983 merges, this can look at `._nativeNode` when present.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.