[Fiber] Transfer everything from Element onto the Fiber and use Tag instead of Stage #6903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Do I understand correctly that you want to stop holding onto the elements? |
|
Yea. That part is a bit minor. A huge win would be to stop holding onto props which we can do too but that's a separate one. E.g. by always rerendering certain components or holding onto it in a WeakMap for ref equality check. |
sebmarkbage
changed the title
|
@sebmarkbage updated the pull request. |
| @@ -97,9 +98,11 @@ function beginWork(unitOfWork : Fiber) : ?Fiber { | |||
| case HostComponent: | |||
| updateHostComponent(unitOfWork); | |||
| break; | |||
| case CoroutineHandlerPhase: | |||
| // This is a restart. Reset the tag to the initial phase. | |||
| unitOfWork.tag = CoroutineHandlerPhase; | |||
There was a problem hiding this comment.
Good catch. This isn't covered by tests yet.
|
lgtm except the inline, as long as tests are the same. |
This has a few benefits: 1) This allows the element to always remain on the young generation. 2) The key can be accessed on the fiber which is easier to keep as the same class and is directly accessible in the child reconciliation of every object. 3) This conveniently means that we don't have to create a fake element for continuations which was really hacky. We can still do the quick bailout of rerendered things using the props object which is also unique.
This gets rid of a field that we only need for coroutines. We might need this if we have multi phase handlers in the future but then maybe we can just use multiple tags.
sebmarkbage
force-pushed
the
newreconciler
branch
from
6e09582
to
811084d
Compare
|
@sebmarkbage updated the pull request. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
[Fiber] Transfer everything from Element onto the Fiber and use Tag instead of Stage (cherry picked from commit 7de2375)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
[Fiber] Transfer everything from Element onto the Fiber and use Tag instead of Stage (cherry picked from commit 7de2375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few benefits:
same class and is directly accessible in the child reconciliation of every
object.
continuations which was really hacky.
We can still do the quick bailout of rerendered things using the props
object which is also unique.
Also I added a commit to use Tag instead of Stage for the coroutine
phase.