Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Transfer everything from Element onto the Fiber and use Tag instead of Stage #6903

Merged
merged 2 commits into from
May 31, 2016
Merged

[Fiber] Transfer everything from Element onto the Fiber and use Tag instead of Stage #6903

merged 2 commits into from
May 31, 2016

Commits on May 31, 2016

  1. Transfer everything from Element onto the Fiber 

    This has a few benefits:

1) This allows the element to always remain on the young generation.
2) The key can be accessed on the fiber which is easier to keep as the
same class and is directly accessible in the child reconciliation of every
object.
3) This conveniently means that we don't have to create a fake element for
continuations which was really hacky.

We can still do the quick bailout of rerendered things using the props
object which is also unique.
    @sebmarkbage
    sebmarkbage committed May 31, 2016
    Configuration menu
    Copy the full SHA
    aa14d89 View commit details
    Browse the repository at this point in the history

  2. Use the tag instead of stage field for coroutine stages 

    This gets rid of a field that we only need for coroutines.

We might need this if we have multi phase handlers in the future
but then maybe we can just use multiple tags.
    @sebmarkbage
    sebmarkbage committed May 31, 2016
    Configuration menu
    Copy the full SHA
    811084d View commit details
    Browse the repository at this point in the history