Prefer node 4.x, npm 2.x in development #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, our test suite won't run properly under npm 3.x, so let's specify our requirement in the package.json. Once npm 3.x goes "final" we'll make sure that we support both. In the meantime, this will prevent developers running the tests from seeing spurious failures like the ones reported here when using npm 3: #396 Tested by installing npm 3, then running `npm install`, and seeing the expected error from the `check-dev-engines.js` script: AssertionError: Current npm version is not supported for development, expected "3.0.0" to satisfy "2.x".
Kept this out of ae02584 in order to keep it easy to read.
|
👍 |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/329483780508680/int_phab to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, our test suite won't run properly under npm 3.x, so let's
specify our requirement in the package.json.
Once npm 3.x goes "final" we'll make sure that we support both. In the
meantime, this will prevent developers running the tests from seeing
spurious failures like the ones reported here when using npm 3:
#396
Tested by installing npm 3, then running
npm install, and seeing theexpected error from the
check-dev-engines.jsscript: