Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating npm dependency to support newer npm versions in the 3.x range #526

Closed
wants to merge 1 commit into from

Conversation

joshblack
Copy link

Currently, when cloning from master and running npm install while running any version of npm@3.x you'll receive an Assertion Error during the prepublish step saying: Current npm version is not supported for development, expected "3.3.9" to satisfy "2.x".

This PR just updates the semver range of the npm devEngine to support npm@3.x versions in addition to npm@2.x ranges.

@zpao
Copy link
Member

zpao commented Oct 30, 2015

This is actually intentional, mostly due to the way we have to use Flow and modules. See #495 & #396 for some previous discussions. So in order to have a reliable development environment, we have to restrict to npm@2

@josephsavona
Copy link
Contributor

@joshblack Thanks for filing this, but due to the restrictions that @zpao mentioned we can't support npm3 yet. I'll close this for now.

@joshblack
Copy link
Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants