Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressed file from stdin does not respect umask #1729

Closed
svenha opened this issue Aug 19, 2019 · 0 comments · Fixed by #1731
Closed

Compressed file from stdin does not respect umask #1729

svenha opened this issue Aug 19, 2019 · 0 comments · Fixed by #1731
Assignees
@felixhandte
Labels
bug

Comments

@svenha
Copy link

svenha commented Aug 19, 2019 •
edited
Loading

patch #1644 causes an unexpected change in 1.4.2 and 1.4.1 (compared to 1.4.0 and before): if compressing from stdin to a file, the file always has final rights 0600 instead of umask. This breaks a lot of code, I fear.
Example:

echo "123456789" | zstd -14 -f -q -o test.zst
chungy added a commit to chungy/zstd that referenced this issue Aug 19, 2019
@chungy
[programs] don’t do chmod on destination file if reading from stdin
d0d0928 
Fixes facebook#1729
@chungy chungy mentioned this issue Aug 19, 2019
Merged
chungy added a commit to chungy/zstd that referenced this issue Aug 20, 2019
@chungy
[programs] don’t do chmod on destination file if reading from stdin
7c57ce4 
Fixes facebook#1729
chungy added a commit to chungy/zstd that referenced this issue Aug 20, 2019
@chungy
[programs] don’t do chmod when coming from stdin or multiple files
f937ea5 
Fixes facebook#1729
chungy added a commit to chungy/zstd that referenced this issue Aug 20, 2019
@chungy
[programs] don’t do chmod when coming from stdin or multiple files
79b973a 
Fixes facebook#1729
chungy added a commit to chungy/zstd that referenced this issue Aug 20, 2019
@chungy
[programs] don’t do chmod when coming from stdin or multiple files
d405a10 
Fixes facebook#1729
@felixhandte felixhandte self-assigned this Aug 27, 2019
chungy added a commit to chungy/zstd that referenced this issue Sep 3, 2019
@chungy
[programs] don’t do chmod when coming from stdin or multiple files
25878b2 
Fixes facebook#1729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixhandte felixhandte

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[programs] don’t do chmod when coming from stdin or multiple files chungy/zstd
2 participants
@felixhandte @svenha