Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[programs] don’t do chmod when coming from stdin or multiple files #1731

Merged
merged 1 commit into from
Oct 14, 2019
Merged

[programs] don’t do chmod when coming from stdin or multiple files #1731

merged 1 commit into from
Oct 14, 2019

Conversation

chungy
Copy link
Contributor

@chungy chungy commented Aug 19, 2019

Fixes #1729

@chungy chungy force-pushed the stdin_nochmod branch 2 times, most recently from 7c57ce4 to f937ea5 Compare August 20, 2019 19:56
@chungy chungy changed the title [programs] don’t do chmod on destination file if reading from stdin [programs] don’t do chmod when coming from stdin or multiple files Aug 20, 2019
@chungy chungy force-pushed the stdin_nochmod branch 2 times, most recently from 79b973a to d405a10 Compare August 20, 2019 19:59
@felixhandte felixhandte self-requested a review August 27, 2019 21:09
@felixhandte felixhandte self-assigned this Aug 27, 2019
@Cyan4973 Cyan4973 merged commit 8b6d968 into facebook:dev Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

@felixhandte felixhandte Awaiting requested review from felixhandte

Assignees

@felixhandte felixhandte

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compressed file from stdin does not respect umask
4 participants
@chungy @Cyan4973 @felixhandte @facebook-github-bot