Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library bloat (with ZSTD_LIB_MINIFY=1) since v1.5.1 #3066

Closed
hchunhui opened this issue Feb 14, 2022 · 1 comment · Fixed by #3366
Closed

Library bloat (with ZSTD_LIB_MINIFY=1) since v1.5.1 #3066

hchunhui opened this issue Feb 14, 2022 · 1 comment · Fixed by #3366
Assignees
@terrelln
Labels
build

Comments

@hchunhui
Copy link

Describe the bug
Build zstd with ZSTD_LIB_MINIFY=1, the size of libzstd.a is increased since v1.5.1.

To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/facebook/zstd
cd zstd

# build recent version (or v1.5.1/v1.5.2)
make -C lib ZSTD_LIB_MINIFY=1 libzstd.a
du -h lib/libzstd.a   # shows 604K

# build v1.5.0
make clean
git checkout v1.5.0
make -C lib ZSTD_LIB_MINIFY=1 libzstd.a
du -h lib/libzstd.a   # shows 328K

Expected behavior
The size of libzstd.a should be ~330K. The first bad commit is 8bf699a.

Desktop (please complete the following information):

  • OS: Debian amd64
  • Version: 11.2
  • Compiler: gcc-10
  • Flags: ZSTD_LIB_MINIFY=1
  • Build system: Makefile
@terrelln terrelln added the build label Dec 16, 2022
terrelln added a commit to terrelln/zstd that referenced this issue Dec 16, 2022
@terrelln
[build] Fix ZSTD_LIB_MINIFY build option
d03ba1b 
`ZSTD_LIB_MINIFY` broke in 8bf699a.

This commit fixes the macro and the static library shrinks from ~600K to 324K
with ZSTD_LIB_MINIFY set.

Fixes facebook#3066.
@terrelln terrelln mentioned this issue Dec 16, 2022
Merged
@terrelln
Copy link
Contributor

Thanks for reporting the issue @hchunhui! Should be fixed after PR #3366 gets merged, and will be included in our next release.

terrelln added a commit to terrelln/zstd that referenced this issue Dec 16, 2022
@terrelln
[build] Fix ZSTD_LIB_MINIFY build option
3ed8888 
`ZSTD_LIB_MINIFY` broke in 8bf699a.

This commit fixes the macro and the static library shrinks from ~600K to 324K
with ZSTD_LIB_MINIFY set.

Fixes facebook#3066.
terrelln added a commit to terrelln/zstd that referenced this issue Dec 16, 2022
@terrelln
[build] Fix ZSTD_LIB_MINIFY build option
432f529 
`ZSTD_LIB_MINIFY` broke in 8bf699a.

This commit fixes the macro and the static library shrinks from ~600K to 324K
with ZSTD_LIB_MINIFY set.

Fixes facebook#3066.
terrelln added a commit to terrelln/zstd that referenced this issue Dec 16, 2022
@terrelln
[build] Fix ZSTD_LIB_MINIFY build option
c9691d9 
`ZSTD_LIB_MINIFY` broke in 8bf699a.

This commit fixes the macro and the static library shrinks from ~600K to 324K
with ZSTD_LIB_MINIFY set.

Fixes facebook#3066.
terrelln added a commit that referenced this issue Dec 16, 2022
@terrelln
[build] Fix ZSTD_LIB_MINIFY build option
0c42424 
`ZSTD_LIB_MINIFY` broke in 8bf699a.

This commit fixes the macro and the static library shrinks from ~600K to 324K
with ZSTD_LIB_MINIFY set.

Fixes #3066.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrelln terrelln

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[build] Fix ZSTD_LIB_MINIFY build option terrelln/zstd
2 participants
@hchunhui @terrelln