[build] Fix ZSTD_LIB_MINIFY build option #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More an opened question : |
Cyan4973
approved these changes
Dec 16, 2022
|
Add a test |
`ZSTD_LIB_MINIFY` broke in 8bf699a. This commit fixes the macro and the static library shrinks from ~600K to 324K with ZSTD_LIB_MINIFY set. Fixes facebook#3066.
Cyan4973
reviewed
Dec 16, 2022
| @@ -236,6 +236,20 @@ jobs: | |||
| # msbuild "build\VS2010\zstd.sln" /m /verbosity:minimal /property:PlatformToolset=v140 | |||
| # /t:Clean,Build /p:Platform=${{matrix.platform}} /p:Configuration=${{matrix.configuration}} | |||
|
|
|||
| # This tests that we don't accidently grow the size too much. | |||
| # If the size grows intentionally, you can raise these numbers. | |||
| # But we do need to think about binary size, since it is a concern. | |||
Cyan4973
approved these changes
Dec 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZSTD_LIB_MINIFYbroke in 8bf699a.This commit fixes the macro and the static library shrinks from ~600K to 324K with ZSTD_LIB_MINIFY set.
Fixes #3066.