This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Adds support for nullish coalescing operator #2076
Closed
claudiopro
wants to merge
4
commits into
facebookarchive:master
from
claudiopro:nullish-coalescing-operator-support
Closed
Adds support for nullish coalescing operator #2076
claudiopro
wants to merge
4
commits into
facebookarchive:master
from
claudiopro:nullish-coalescing-operator-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiopro
force-pushed
the
nullish-coalescing-operator-support
branch
from
June 12, 2019 15:26
77c8b7d
to
ec5eaf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
noahlemen
reviewed
Jun 12, 2019
noahlemen
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @NoamELB! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@claudiopro merged this pull request in 96c7221. |
Closed
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Adds support for nullish coalescing operator which was missing from the babel config of the OSS repo. **Test Plan** `yarn` Verify Travis CI tests pass Pull Request resolved: facebookarchive#2076 Differential Revision: D15781518 Pulled By: claudiopro fbshipit-source-id: 4d6deb3503dfbbcf142a8dbaa10ebc2ec8e7a1c4
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: **Summary** Adds support for nullish coalescing operator which was missing from the babel config of the OSS repo. **Test Plan** `yarn` Verify Travis CI tests pass Pull Request resolved: facebookarchive#2076 Differential Revision: D15781518 Pulled By: claudiopro fbshipit-source-id: 4d6deb3503dfbbcf142a8dbaa10ebc2ec8e7a1c4
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Adds support for nullish coalescing operator which was missing from the babel config of the OSS repo. **Test Plan** `yarn` Verify Travis CI tests pass Pull Request resolved: facebookarchive/draft-js#2076 Differential Revision: D15781518 Pulled By: claudiopro fbshipit-source-id: 4d6deb3503dfbbcf142a8dbaa10ebc2ec8e7a1c4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for nullish coalescing operator which was missing from the babel config of the OSS repo.
Test Plan
yarn
Verify Travis CI tests pass