Upgrade eslint + flow #2083

lukyth · 2019-05-23T07:50:02Z

Summary

I want to upgrade ESLint and Flow on this project. I ended up with

Remove unused eslint-plugin-relay
Upgrade all ESLint packages to the latest version and fix all the new lint errors afterward.
- eslint-config-fbjs
- eslint-config-prettier
- eslint-plugin-babel
- eslint-plugin-flowtype
- eslint-plugin-jsx-a11y
- eslint-plugin-prettier
- eslint-plugin-react
Upgrade Flow (flow-bin) to the 0.115.0.

~~Then I found that yarn test is failing at~~

src/component/handlers/composition/__tests__/DraftEditorCompostionHandler-test.js: Support for the experimental syntax 'nullishCoalescingOperator' isn't currently enabled (70:40)

~~So I added @babel/plugin-proposal-nullish-coalescing-operator to jest preprocessor as well.~~
Move plugins in .babelrc to jest preprocessor as #2083 (comment)

Test Plan

yarn lint, yarn flow, and yarn test should all pass.

claudiopro · 2019-06-14T09:08:04Z

Hi @lukyth, thanks for contributing a fix to Draft.js! 🎉 Unfortunately I had already started working on this change with #2076 a few days earlier, but I like your change to add the babel plugin to the Jest preprocessor better:

  process(src, filename) {
    var options = {
      presets: [fbjsConfigurePreset({rewriteModules: {map: moduleMap}})],
+     plugins: [require('@babel/plugin-proposal-nullish-coalescing-operator')],
      filename: filename,
      retainLines: true,
    };

whereas I added a .babelrc file. Do you mind rebasing and proposing this change again? I'd really love to get this added and give you credit in the commit history.

src/model/immutable/ContentBlockNode.js

According to facebookarchive#2083 (comment)

lukyth · 2019-06-14T10:47:05Z

Hi @claudiopro :) Thank you for your comments! I rebased the branch against master and brought back the type coercion. I also took this change to upgrade eslint-plugin-jsx-a11y, eslint-plugin-prettier, and eslint-plugin-react as well. Please have a look again 🙏

I tried to upgrade flow-bin pass version 0.98.1 but it will cause an error from node_modules. facebook/fbjs#346 need to be released first in order to upgrade to a newer version than 0.98.1.

claudiopro

Please take a look at my comments. Since you're configuring the babel plugin @babel/plugin-proposal-nullish-coalescing-operator in the Jest preprocessor, you should remove the .babelrc file which is not necessary anymore.

package.json

src/.flowconfig

src/model/modifier/__tests__/AtomicBlockUtils-test.js

.eslintrc.js

Ref: facebookarchive#2083 (comment)

lukyth · 2019-06-14T17:59:18Z

@claudiopro I took care of @babel/plugin-proposal-nullish-coalescing-operator 😄, but upgrading flow-bin to a version newer than 0.98.1 will requires facebook/fbjs#346 to be released first 😞.

one warning was autofixed

mrkev · 2020-01-14T21:01:32Z

Cool stuff! I want to see what the internal linters say about this.

facebook-github-bot

@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

lukyth · 2020-01-15T13:14:56Z

@mrkev Thanks for checking it out :)

mrkev · 2020-01-15T20:40:10Z

There's a linter warning, but it should be fine. I'll try to get this merged today.

facebook-github-bot · 2020-01-15T21:55:23Z

@mrkev merged this pull request in 824fd12.

…ator (facebookarchive#2083) Summary: **Summary** I want to upgrade ESLint and Flow on this project. I ended up with - Remove unused `eslint-plugin-relay` - Upgrade all ESLint packages to the latest version and fix all the new lint errors afterward. - `eslint-config-fbjs` - `eslint-config-prettier` - `eslint-plugin-babel` - `eslint-plugin-flowtype` - `eslint-plugin-jsx-a11y` - `eslint-plugin-prettier` - `eslint-plugin-react` - Upgrade Flow (`flow-bin`) to the `0.115.0`. ~Then I found that `yarn test` is failing at~ ``` src/component/handlers/composition/__tests__/DraftEditorCompostionHandler-test.js: Support for the experimental syntax 'nullishCoalescingOperator' isn't currently enabled (70:40) ``` ~So I added `babel/plugin-proposal-nullish-coalescing-operator` to jest preprocessor as well.~ Move plugins in `.babelrc` to jest preprocessor as facebookarchive#2083 (comment) **Test Plan** `yarn lint`, `yarn flow`, and `yarn test` should all pass. Pull Request resolved: facebookarchive#2083 Reviewed By: claudiopro Differential Revision: D19398251 Pulled By: mrkev fbshipit-source-id: 4fc2f6dd6e0cd44266d061455b7b6a433231715a

…ator (#2083) Summary: **Summary** I want to upgrade ESLint and Flow on this project. I ended up with - Remove unused `eslint-plugin-relay` - Upgrade all ESLint packages to the latest version and fix all the new lint errors afterward. - `eslint-config-fbjs` - `eslint-config-prettier` - `eslint-plugin-babel` - `eslint-plugin-flowtype` - `eslint-plugin-jsx-a11y` - `eslint-plugin-prettier` - `eslint-plugin-react` - Upgrade Flow (`flow-bin`) to the `0.115.0`. ~Then I found that `yarn test` is failing at~ ``` src/component/handlers/composition/__tests__/DraftEditorCompostionHandler-test.js: Support for the experimental syntax 'nullishCoalescingOperator' isn't currently enabled (70:40) ``` ~So I added `babel/plugin-proposal-nullish-coalescing-operator` to jest preprocessor as well.~ Move plugins in `.babelrc` to jest preprocessor as facebookarchive/draft-js#2083 (comment) **Test Plan** `yarn lint`, `yarn flow`, and `yarn test` should all pass. Pull Request resolved: facebookarchive/draft-js#2083 Reviewed By: claudiopro Differential Revision: D19398251 Pulled By: mrkev fbshipit-source-id: 4fc2f6dd6e0cd44266d061455b7b6a433231715a

facebook-github-bot added the CLA Signed label May 23, 2019

claudiopro reviewed Jun 14, 2019

View reviewed changes

src/model/immutable/ContentBlockNode.js Outdated Show resolved Hide resolved

lukyth added 5 commits June 14, 2019 19:21

Remove unused eslint-plugin-relay

218304c

Upgrade all ESLint dependencies

871cbcd

Upgrade flow

bfeb193

Fix test failed from nullish-coalescing-operator

dfe2989

Bring back type coercion since removing it breaks Facebook internal code

83385bc

According to facebookarchive#2083 (comment)

lukyth force-pushed the lukyth/chore branch from a45d274 to 4e328bb Compare June 14, 2019 10:42

claudiopro suggested changes Jun 14, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

src/.flowconfig Outdated Show resolved Hide resolved

src/model/modifier/__tests__/AtomicBlockUtils-test.js Outdated Show resolved Hide resolved

.eslintrc.js Outdated Show resolved Hide resolved

lukyth added 2 commits June 15, 2019 02:56

Remove unnecessary .babelrc and redundant dependency

ecefa06

Ref: facebookarchive#2083 (comment)

Commit bundle-size-stats

be6e002

lukyth force-pushed the lukyth/chore branch from 4e328bb to be6e002 Compare June 14, 2019 17:56

lukyth added 5 commits January 14, 2020 21:35

Merge branch 'master' into lukyth/chore

cea1ede

Upgrade eslint modules

69d4e47

one warning was autofixed

Upgrade flow

631c226

Move test related babel plugin to jest proprocessor

8f90ef5

Remove unused eslint-plugin-relay

2c640fe

facebook-github-bot reviewed Jan 14, 2020

View reviewed changes

lukyth changed the title ~~Upgrade eslint + flow, and fix failed test from nullishCoalescingOperator~~ Upgrade eslint + flow Jan 15, 2020

facebook-github-bot closed this in 824fd12 Jan 15, 2020

facebook-github-bot added the Merged label Jan 15, 2020

lukyth deleted the lukyth/chore branch January 17, 2020 15:30

claudiopro mentioned this pull request Jan 28, 2020

fix(lint): removes unnecessary Boolean cast #2290

Closed

wingn8t mentioned this pull request Jun 14, 2024

[Snyk] Upgrade draft-js from 0.10.5 to 0.11.7 wingn8t/wagtail#2

Open

YinghanFeng mentioned this pull request Aug 2, 2024

[Snyk] Upgrade draft-js from 0.10.5 to 0.11.7 YinghanFeng/autodll-webpack-plugin#2

Open

wingn8t mentioned this pull request Aug 6, 2024

[Snyk] Upgrade draft-js from 0.10.5 to 0.11.7 wingn8t/wagtail#4

Open

wingn8t mentioned this pull request Aug 20, 2024

[Snyk] Upgrade draft-js from 0.10.5 to 0.11.7 wingn8t/wagtail#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade eslint + flow #2083

Upgrade eslint + flow #2083

lukyth commented May 23, 2019 •

edited

Loading

claudiopro commented Jun 14, 2019

lukyth commented Jun 14, 2019 •

edited

Loading

claudiopro left a comment

lukyth commented Jun 14, 2019

mrkev commented Jan 14, 2020

facebook-github-bot left a comment

lukyth commented Jan 15, 2020

mrkev commented Jan 15, 2020

facebook-github-bot commented Jan 15, 2020

Upgrade eslint + flow #2083

Upgrade eslint + flow #2083

Conversation

lukyth commented May 23, 2019 • edited Loading

claudiopro commented Jun 14, 2019

lukyth commented Jun 14, 2019 • edited Loading

claudiopro left a comment

Choose a reason for hiding this comment

lukyth commented Jun 14, 2019

mrkev commented Jan 14, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

lukyth commented Jan 15, 2020

mrkev commented Jan 15, 2020

facebook-github-bot commented Jan 15, 2020

lukyth commented May 23, 2019 •

edited

Loading

lukyth commented Jun 14, 2019 •

edited

Loading