This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
chore(travis): bumps node versions used in Travis CI to 10 and 12 #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
nice |
|
@claudiopro merged this pull request in e711230. |
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
…cebookarchive#2300) Summary: **Summary** As of January 2020, Node 8 is past Active LTS end of life. This PR removes Node 8 from the Travis CI environment config and replaces it with Node 12. https://nodejs.org/en/about/releases/ **Test Plan** Tested locally building all targets on Node 12 with [nvm](http://nvm.sh/) ``` nvm use 12 yarn ``` Pull Request resolved: facebookarchive#2300 Reviewed By: mrkev Differential Revision: D19298082 Pulled By: claudiopro fbshipit-source-id: 0ce83534231f1b881b2f56e0410e99319d0f2365
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
…cebookarchive#2300) Summary: **Summary** As of January 2020, Node 8 is past Active LTS end of life. This PR removes Node 8 from the Travis CI environment config and replaces it with Node 12. https://nodejs.org/en/about/releases/ **Test Plan** Tested locally building all targets on Node 12 with [nvm](http://nvm.sh/) ``` nvm use 12 yarn ``` Pull Request resolved: facebookarchive#2300 Reviewed By: mrkev Differential Revision: D19298082 Pulled By: claudiopro fbshipit-source-id: 0ce83534231f1b881b2f56e0410e99319d0f2365
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
…300) Summary: **Summary** As of January 2020, Node 8 is past Active LTS end of life. This PR removes Node 8 from the Travis CI environment config and replaces it with Node 12. https://nodejs.org/en/about/releases/ **Test Plan** Tested locally building all targets on Node 12 with [nvm](http://nvm.sh/) ``` nvm use 12 yarn ``` Pull Request resolved: facebookarchive/draft-js#2300 Reviewed By: mrkev Differential Revision: D19298082 Pulled By: claudiopro fbshipit-source-id: 0ce83534231f1b881b2f56e0410e99319d0f2365
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of January 2020, Node 8 is past Active LTS end of life. This PR removes Node 8 from the Travis CI environment config and replaces it with Node 12.
https://nodejs.org/en/about/releases/
This PR also updates supported Node versions in
package.jsonto 10, 12 and 13.Test Plan
Tested locally building all targets on Node 12 with nvm