Skip to content

Commit

Permalink
chore(travis): bumps node versions used in Travis CI to 10 and 12 (fa…
Browse files Browse the repository at this point in the history
…cebookarchive#2300)

Summary:
**Summary**

As of January 2020, Node 8 is past Active LTS end of life. This PR removes Node 8 from the Travis CI environment config and replaces it with Node 12.

https://nodejs.org/en/about/releases/

**Test Plan**

Tested locally building all targets on Node 12 with [nvm](http://nvm.sh/)
```
nvm use 12
yarn
```
Pull Request resolved: facebookarchive#2300

Reviewed By: mrkev

Differential Revision: D19298082

Pulled By: claudiopro

fbshipit-source-id: 0ce83534231f1b881b2f56e0410e99319d0f2365
  • Loading branch information
Claudio Procida authored and mmissey committed Mar 24, 2020
1 parent 86a2f23 commit 5e5bbc6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
language: node_js

node_js:
- 8
- 10
- 12

sudo: false

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"webpack-stream": "^4.0.0"
},
"devEngines": {
"node": "8.x || 9.x || 10.x",
"node": "10.x || 12.x || 13.x",
"npm": "2.x || 3.x || 5.x || 6.x"
},
"jest": {
Expand Down

0 comments on commit 5e5bbc6

Please sign in to comment.