This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Adds BLM banner #2454
Closed
Adds BLM banner #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yangshun I have no idea how to add a banner above the navbar. Is this possible with a declarative config like the one we have here? |
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
noahlemen
approved these changes
Jun 2, 2020
|
Thank you @kedromelon! |
|
@claudiopro merged this pull request in 2a0c5bb. |
|
@claudiopro the current PR works, but if you want to apply it to all pages, you can use the announcement bar feature. An example PR - facebookexperimental/Recoil#241 |
|
Thank you @yangshun, I'll look into this today! |
|
Because of this change, the site became inaccessible What happened to links It is hard to see links. |
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** Adds a Black Lives Matter banner like other OSS projects of the React family **Test Plan** Local tests ``` cd website yarn yarn start ``` ## Screenshots <img width="752" alt="Screen Shot 2020-06-02 at 21 10 00" src="https://user-images.githubusercontent.com/860099/83565342-2a8d7a80-a516-11ea-9eb8-697f1f781a4c.png"> <img width="1392" alt="Screen Shot 2020-06-02 at 21 09 18" src="https://user-images.githubusercontent.com/860099/83565335-26615d00-a516-11ea-8e6f-cad0d3f3cc2f.png"> <img width="1072" alt="Screen Shot 2020-06-02 at 21 10 07" src="https://user-images.githubusercontent.com/860099/83565349-2bbea780-a516-11ea-85d8-c9da292998c7.png"> Pull Request resolved: facebookarchive#2454 Reviewed By: mrkev Differential Revision: D21849517 Pulled By: claudiopro fbshipit-source-id: c4b8944b7cbfbe9603bde4ad5128f3826ecb1f04
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Adds a Black Lives Matter banner like other OSS projects of the React family **Test Plan** Local tests ``` cd website yarn yarn start ``` ## Screenshots <img width="752" alt="Screen Shot 2020-06-02 at 21 10 00" src="https://user-images.githubusercontent.com/860099/83565342-2a8d7a80-a516-11ea-9eb8-697f1f781a4c.png"> <img width="1392" alt="Screen Shot 2020-06-02 at 21 09 18" src="https://user-images.githubusercontent.com/860099/83565335-26615d00-a516-11ea-8e6f-cad0d3f3cc2f.png"> <img width="1072" alt="Screen Shot 2020-06-02 at 21 10 07" src="https://user-images.githubusercontent.com/860099/83565349-2bbea780-a516-11ea-85d8-c9da292998c7.png"> Pull Request resolved: facebookarchive/draft-js#2454 Reviewed By: mrkev Differential Revision: D21849517 Pulled By: claudiopro fbshipit-source-id: c4b8944b7cbfbe9603bde4ad5128f3826ecb1f04
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Black Lives Matter banner like other OSS projects of the React family
Test Plan
Local tests
Screenshots