Add BLM banner as announcement bar #241
Conversation
|
Hi @theobr! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Why was this closed? @davidmccabe |
There was a problem hiding this comment.
@davidmccabe Took you 13 minutes to close this but you didn't explain why. We'd like to hear your reasoning.
| announcementBar: { | ||
| id: 'black_lives_matter', | ||
| content: | ||
| '<div class="blm-bar">Black Lives Matter. <a style="color: rgb(97, 218, 251)" target="_blank" href="https://support.eji.org/give/153413/#!/donation/checkout">Support the Equal Justice Innitiative</a></div>', |
There was a problem hiding this comment.
Oh man I copy-pasted this I have no idea how that happened 😅 good catch!
|
Hi, I'd also like to see your reasoning here @davidmccabe. |
|
Noticed. Disappointed by this quick closing with no reasoning. |
|
I was really excited by Recoil, I was readying a blog post about it last week and I had been promoting it on Twitter. I'm not going to publish that blog post, and I'm not going to be using Recoil. |
|
@jamiebuilds I don't think that just because they have rejected the PR they don't support BLM. In fact, the banner itself is quite obtrusive. Dev.to has a much better one. Please don't give up on recoil and your blog post. |
|
I just wish we could hear something from |
Styling copied from React's topnav CTA