Building with carthage results in 2 Bolts.framework being built?

[Nonnus]

Facebook Swift SDK Issue

Checklist

• I've updated to the latest released version of the SDK
• I've searched for existing GitHub issues
• I've looked for existing answers on Stack Overflow and the Facebook Developers Group
• I've read the Code of Conduct
• This issue is not security related and can safely be disclosed publicly on GitHub

Environment

When doing a clean build using carthage we end up with 2 Bolts frameworks, one in build folder and another in build/static folder (wich i assume it a static version of the framework):
this feels wrong and seems to be undocumented, is it an expected behavior?
wich of them should we include in our projects?

• Xcode Version: 9.4.1
• Swift Version: 4.1.2
• Installation Platform & Verison: Carthage version 0.30.1

Issue Details

• Bugs: Please fill out all the sections below
• Feature Request: Please fill out the first two sections below, remove the rest of the sections, AND give your issue the title: Feature Request: [name of your feature request]

Goals

Build swift facebook sdk using carthage

Expected Results

End up with only one build Bolts framework

Actual Results

Ended up with 2 Bolts frameworks being built in different folders:

Steps to Reproduce

1 Create blank project
2 Add Cartfile with github "facebook/Facebook-SDK-Swift"
3 run carthage update --platform ios

Code Samples & Details

FB-Test.zip

[vitorhugomagalhaes]

@Nonnus It seems that one is the dynamic and the other the static one. Not sure if this is an issue.

[Nonnus]

i had that notion as well (even mentioned it on my initial issue description)
but it would still be nice to have more info about it,
in the integration docs there is no mention of this aspect,
nor any instructions about adding the dynamic vs static version of the framework as there are slight differences (mainly skipping the copy-frameworks build phase for the static version of the framework)

[vitorhugomagalhaes]

True. Moreover I'd like to see some "standardisation" across different carthage packages to make this more clear for everyone.

[codytwinton]

Thanks for reporting this issue. I'm doing some work with the underlying Objective-C SDK right now, but I'll do my best to address this asap.

[Nonnus]

@codytwinton i assumed so, this is why i did not even @mentioned you not to disturb ;)

[codytwinton]

@Nonnus - Great news, it appears that a similar pull request on the Bolts framework was approved and merged. This might be resolved with BoltsFramework/Bolts-ObjC#324.

[Nonnus]

@codytwinton great news! I suppose a new release will be generated so that it can be automatically picked up when building facebook-sdk-swift

[codytwinton]

facebook-objc-sdk master branch now targets the latest version of Bolts.

[Nonnus]

@codytwinton testing right now

[codytwinton]

@Nonnus let me know.

[Nonnus]

@codytwinton I assume it requires carthage to be updated to 0.31.0?
I still had 0.30.1 and running carthage update Facebook-SDK-Swift --platform ios failed:

[Nonnus]

@codytwinton same with carthage 0.31.0:

here is the build log:
carthage-xcodebuild.58iRaH.log

[codytwinton]

@Nonnus - I believe so, yes.

[codytwinton]

@Nonnus - damn, ok. This appears to be an issue with Xcode 10 still, but I believe I might know the root cause. I'll check this out and confirm shortly.

[Nonnus]

@codytwinton I updated my previous post with my build log, It might help:

[codytwinton]

Can you update your Cartfile to target the master branch for the facebook-objc-sdk?

[Nonnus]

running it now (I was actually not including it on the cartfile, nor Bolts, only Facebook-SDK-Swift, I assume this should be fine once the setup is fixed?)
I was going to tell you that I noticed on my Cartfile.resolved that checked out Bolts was still on 1.9.0

[codytwinton]

Yes, once everything is resolved and all cartfile's are updated properly, this will be just fine.

[Nonnus]

not, it failed again, I am afraid :(
I am a bit suspicious about this: facebook-objc-sdk is now at commit 79caaaf56ce3eb00a0a7852361d4c250459f2e43 (latest master commit) but checkout Bolts on my Cartfile.resolved is still 1.9.0:

build log:
carthage-xcodebuild.lkKXNy.log

[codytwinton]

Also could be related to this:

facebook/facebook-ios-sdk#914 (comment)

[codytwinton]

This should be resolved with version 0.5.0