Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Xcode 10 #914

Closed
wants to merge 3 commits into from
Closed

Support Xcode 10 #914

wants to merge 3 commits into from

Conversation

chuganzy
Copy link
Contributor

@chuganzy chuganzy commented Sep 26, 2018 •
edited
Loading

  • sign contributor license agreement
  • submit against our dev branch, not master.
    I cannot see dev branch anymore
  • describe the change (for example, what happens before the change, and after the change)

This PR supports building the project with Xcode10.

@chuganzy chuganzy mentioned this pull request Sep 26, 2018
Closed
codytwinton
codytwinton suggested changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@codytwinton codytwinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you neglected to update the Carthage Cartfile. Can you please do so?

@chuganzy
Copy link
Contributor Author

chuganzy commented Sep 26, 2018 •
edited
Loading

@codytwinton Aha, I totally missed that; directly updated submodule 😅 Addressed it, review again please 🙏

facebook-github-bot
facebook-github-bot reviewed Sep 27, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codytwinton has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@chuganzy chuganzy deleted the update-bolts branch September 27, 2018 21:52
@chuganzy
Copy link
Contributor Author

@codytwinton Sorry if you are still working on this but looks 79caaaf is missing cb19f08

@codytwinton
Copy link
Contributor

@chuganzy - Yes, this file was actually changed recently in 5670dc0

Everything should be good now.

@chuganzy
Copy link
Contributor Author

@codytwinton The change is still needed - FBSDKUserDataStore.m is not added to FBSDKCoreKit-Dynamic and cannot build the target.

@codytwinton codytwinton mentioned this pull request Sep 27, 2018
Closed
5 tasks
@codytwinton
Copy link
Contributor

@chuganzy - Good catch. I've got a fix internally waiting for review, then I'll push out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@codytwinton codytwinton codytwinton requested changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuganzy @codytwinton @facebook-github-bot