Perform clean by deleting build directory instead #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuganzy
force-pushed
the
new-build-system-fix
branch
from
204b746 to
df5c4a7
Compare
This was referenced Sep 26, 2018
3 tasks
facebook-github-bot
pushed a commit
to facebook/facebook-ios-sdk
that referenced
this pull request
Sep 27, 2018
Summary: - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla) - [x] submit against our `dev` branch, not `master`. I cannot see `dev` branch anymore - [x] describe the change (for example, what happens before the change, and after the change) This PR supports building the project with Xcode10. - Apply BoltsFramework/Bolts-ObjC#324 - Also fixes the issue that `FBSDKUserDataStore` is not added to `FBSDKCoreKit-Dynamic`. Pull Request resolved: #914 Reviewed By: jingping2015 Differential Revision: D10092089 Pulled By: codytwinton fbshipit-source-id: 39f625643cdee6638cde56df24e87a18f890edd7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easiest way to support Xcode 10
As per this comment: #323 (comment)