Improve dependency install and build #10920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
force-pushed
the
fix-fmt
branch
2 times, most recently
from
949f30d
to
2609922
Compare
majetideepak
changed the title
majetideepak
force-pushed
the
fix-fmt
branch
7 times, most recently
from
3bb77cf
to
c1e5220
Compare
czentgr
reviewed
Sep 4, 2024
scripts/setup-adapters.sh
Outdated
| @@ -144,7 +144,8 @@ function install_hdfs_deps { | |||
| wget_and_untar https://archive.apache.org/dist/hadoop/common/hadoop-2.10.1/hadoop-2.10.1.tar.gz hadoop | |||
| cp -a hadoop /usr/local/ | |||
| fi | |||
| cmake_install $libhdfs3_dir | |||
| cd $libhdfs3_dir | |||
There was a problem hiding this comment.
If we don't leave this dir and it is not in () would we not be in the wrong dir at the end of the function?
There was a problem hiding this comment.
Yes! Good catch!
majetideepak
force-pushed
the
fix-fmt
branch
3 times, most recently
from
0f4d6d0
to
929314b
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Summary: Brew fmt11 is not supported. ccache brings in fmt11 from brew. The brew fmt11 headers are taking precedence over bundled headers. Bundle fmt and download prebuilt ccache that is statically linked. We will fix the header include issue in #10920 and add ccache back. Resolves #10936 Pull Request resolved: #10933 Reviewed By: amitkdutta Differential Revision: D62256989 Pulled By: kgpai fbshipit-source-id: 84aa17af17d564f291c416b479493bd9e5ea0715
majetideepak
changed the title
majetideepak
force-pushed
the
fix-fmt
branch
2 times, most recently
from
afc86a5
to
361e318
Compare
zuyu
reviewed
Sep 6, 2024
| if [ -d "${BINARY_DIR}" ] && prompt "Do you want to rebuild ${NAME}?"; then | ||
| ${SUDO} rm -rf "${BINARY_DIR}" | ||
| if [ -d "${BINARY_DIR}" ]; then | ||
| if prompt "Do you want to rebuild ${NAME}?"; then |
There was a problem hiding this comment.
Since you are updating cmake_install, please fix ${NAME} per #10908, and then I will close my PR. Thanks!
Sth like
local DIR="${DEPENDENCY_DIR}/$1"
local NAME=${basename "${DIR}"}
pushd "${DIR}"There was a problem hiding this comment.
My PR fixes this by moving pushd $DIR above NAME.
Your change is not needed.
zuyu
reviewed
Sep 6, 2024
README.md
Outdated
| $ export DEPENDENCY_DIR=/path/to/your/dependencies | ||
| ``` | ||
| location to download and build packages. This defaults to `deps-download` in the current | ||
| working directory. Use `INSTALL_PREFIX` to set the install directory of the packages. |
There was a problem hiding this comment.
nit: could we start INSTALL_PREFIX env in a new paragraph for clarity?
majetideepak
force-pushed
the
fix-fmt
branch
from
361e318
to
f2c6be4
Compare
majetideepak
force-pushed
the
fix-fmt
branch
3 times, most recently
from
3d7cd1a
to
c51fdc4
Compare
czentgr
reviewed
Sep 13, 2024
majetideepak
force-pushed
the
fix-fmt
branch
from
3aeea9c
to
9ee3202
Compare
czentgr
approved these changes
Sep 16, 2024
majetideepak
force-pushed
the
fix-fmt
branch
from
9ee3202
to
50f9065
Compare
majetideepak
added
ready-to-merge
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kgpai
approved these changes
Sep 18, 2024
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/facebookincubator/velox/pull/10422/files added additional packages to be installed via brew.
When the package versions are updated via brew, it can cause a build failure.
See #10886
We must install or bundle fixed/supported versions to avoid this.
Allow installed package headers to be picked up before brew/system package headers
Add support for DEPENDENCY_DIR and INSTALL_PREFIX.