Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lib stemmer in setup scripts #10984

Closed
wants to merge 3 commits into from
Closed

Add lib stemmer in setup scripts #10984

wants to merge 3 commits into from

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Sep 12, 2024 •
edited
Loading

The early merged pr (38f9a1f) was reverted by #10965 due to this issue: #10963.

In the original impl., a patch is expected to be applied to add -fPIC before building lib
stemmer, but when building docker image (ghcr.io/facebookincubator/velox-dev:centos9),
that patch file is not available to use due to the copied setup script outside velox repo is
executed. See code:

velox/scripts/centos.dockerfile

Line 22 in 7f2d7ad

RUN mkdir build && ( cd build && bash /setup-centos9.sh ) && rm -rf build && \

This pr proposes the installation of lib stemmer with the above issue fixed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 12, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a1ee399
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66f49d890593010008937252

@PHILO-HE PHILO-HE force-pushed the find-stemmer-v2 branch 7 times, most recently from 45710db to e48a0e4 Compare September 13, 2024 03:26
@PHILO-HE PHILO-HE changed the title Add Findstemmer.cmake to find lib stemmer Install lib stemmer in setup script Sep 13, 2024
@PHILO-HE
Copy link
Contributor Author

@kgpai, I just broke down my reverted pr into two. This one only covers the installation of libstemmer and I will create another pr to add Findstemmer.cmake. Could you please review this pr? Thanks!

@PHILO-HE PHILO-HE changed the title Install lib stemmer in setup script Add lib stemmer in setup script Sep 13, 2024
@PHILO-HE PHILO-HE mentioned this pull request Sep 13, 2024
Closed
@PHILO-HE PHILO-HE force-pushed the find-stemmer-v2 branch 2 times, most recently from 7c453ff to 8a7416b Compare September 18, 2024 07:09
@PHILO-HE
Copy link
Contributor Author

Friendly ping @kgpai, could you review this pr? The CI failure is not related.

@PHILO-HE
Copy link
Contributor Author

@assignUser, could you take a look also?

kgpai
kgpai reviewed Sep 20, 2024
View reviewed changes
scripts/setup-centos9.sh Outdated Show resolved Hide resolved
@PHILO-HE
Copy link
Contributor Author

@kgpai, @majetideepak, thanks so much for your comments! Could you take a look again?

majetideepak
majetideepak approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PHILO-HE

@majetideepak majetideepak changed the title Add lib stemmer in setup script Add lib stemmer in linux setup scripts Sep 23, 2024
@majetideepak
Copy link
Collaborator

@PHILO-HE should we add this for macos setup script as well?

@assignUser
Copy link
Collaborator

+1 on adding it to macos script as well

assignUser
assignUser approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The redundancy will be cleaned up with #10670

@assignUser
Copy link
Collaborator

I just noticed that the macos jobs where not triggered, could you add scripts/setup-macos.sh to the paths: filter in macos.yml?

@PHILO-HE
Copy link
Contributor Author

I just noticed that the macos jobs where not triggered, could you add scripts/setup-macos.sh to the paths: filter in macos.yml?

@assignUser, yes, we should add it. Just updated the pr.

@assignUser assignUser added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Sep 24, 2024
@majetideepak majetideepak changed the title Add lib stemmer in linux setup scripts Add lib stemmer in setup scripts Sep 24, 2024
@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@PHILO-HE
Copy link
Contributor Author

@Yuhta, I just resolved code conflict. Could you please re-import the pull request?

@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Yuhta
Copy link
Contributor

Yuhta commented Sep 25, 2024

@PHILO-HE Can you rebase again? There was another PR changing the same file

@PHILO-HE
Copy link
Contributor Author

@PHILO-HE Can you rebase again? There was another PR changing the same file

@Yuhta, rebased. Thanks for your reminding!

@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Yuhta merged this pull request in 783c233.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 783c2335.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

facebook-github-bot pushed a commit that referenced this pull request Sep 30, 2024
@PHILO-HE @facebook-github-bot
Add Findstemmer.cmake to find lib stemmer (#10998)
92779f9 
Summary:
Lib stemmer can be installed through setup script. See #10984.
This pr allows cmake to find installed lib stemmer.

Pull Request resolved: #10998

Reviewed By: xiaoxmeng, DanielHunte

Differential Revision: D63569657

Pulled By: kagamiori

fbshipit-source-id: e0e0c2402616a7e9f194665363bcfc0208303fe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpai kgpai kgpai left review comments

@majetideepak majetideepak majetideepak approved these changes

@assignUser assignUser assignUser approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PHILO-HE @majetideepak @assignUser @facebook-github-bot @Yuhta @kgpai