Back out "Add Findstemmer.cmake to find lib stemmer" #10965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D62477240 |
kagamiori
approved these changes
Sep 11, 2024
…or#10965) Summary: Pull Request resolved: facebookincubator#10965 Reverting PR facebookincubator#10884 due to it breaking PyVelox builds and Fuzzer . Fixes issue : facebookincubator#10963 Original commit changeset: dec13d672129 Original Phabricator Diff: D62373662 Reviewed By: xiaoxmeng, amitkdutta, kagamiori Differential Revision: D62477240
|
This pull request was exported from Phabricator. Differential Revision: D62477240 |
kgpai
force-pushed
the
export-D62477240
branch
from
dc49a87
to
a12c4ec
Compare
majetideepak
approved these changes
Sep 11, 2024
|
This pull request has been merged in 485329e. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
Summary: The early merged pr (38f9a1f) was reverted by #10965 due to this issue: #10963. In the original impl., a patch is expected to be applied to add `-fPIC` before building lib stemmer, but when building docker image (ghcr.io/facebookincubator/velox-dev:centos9), that patch file is not available to use due to the copied setup script outside velox repo is executed. See code: https://github.com/facebookincubator/velox/blob/7f2d7adaa1544c72129fd1c8d0766755ff354455/scripts/centos.dockerfile#L22 This pr proposes the installation of lib stemmer with the above issue fixed. Pull Request resolved: #10984 Reviewed By: DanielHunte Differential Revision: D63344087 Pulled By: Yuhta fbshipit-source-id: a1467f5392ef828efdd219d0b7f1dfe0003d00ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reverting PR #10884 due to it breaking PyVelox builds and Fuzzer .
Fixes issue : #10963
Original commit changeset: dec13d672129
Original Phabricator Diff: D62373662
Reviewed By: amitkdutta
Differential Revision: D62477240