Make sure inputFlatNoNulls_ is initialized in ctor #11140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D63673714 |
amberMZ
pushed a commit
to amberMZ/velox
that referenced
this pull request
Oct 1, 2024
…#11140) Summary: Pull Request resolved: facebookincubator#11140 when `inputFlatNoNulls_` is not initialized, it could result in undefined behavior like one described in https://www.internalfb.com/diff/D63556283?dst_version_fbid=804905691596581&transaction_fbid=550949777494622 This diff initializes inputFlatNoNulls_ as false. Differential Revision: D63673714
amberMZ
force-pushed
the
export-D63673714
branch
from
38e066b
to
c8fd98d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63673714 |
…ncubator#11140) Summary: when `inputFlatNoNulls_` is not initialized, it could result in undefined behavior like one described in https://www.internalfb.com/diff/D63556283?dst_version_fbid=804905691596581&transaction_fbid=550949777494622 This diff initializes inputFlatNoNulls_ as false. Differential Revision: D63673714
amberMZ
force-pushed
the
export-D63673714
branch
from
c8fd98d
to
510858e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63673714 |
xiaoxmeng
approved these changes
Oct 4, 2024
|
This pull request has been merged in e8db673. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
when
inputFlatNoNulls_is not initialized, it could result in undefined behavior like one described in https://www.internalfb.com/diff/D63556283?dst_version_fbid=804905691596581&transaction_fbid=550949777494622This diff initializes inputFlatNoNulls_ as false.
Differential Revision: D63673714