Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure inputFlatNoNulls_ is initialized in ctor #11140

Closed
wants to merge 1 commit into from
Closed

Make sure inputFlatNoNulls_ is initialized in ctor #11140

wants to merge 1 commit into from

Commits on Oct 4, 2024

  1. Make sure inputFlatNoNulls_ is initialized in EvalCtx ctor (facebooki… 

    …ncubator#11140)

Summary:

when `inputFlatNoNulls_` is not initialized, it could result in undefined behavior like one described in https://www.internalfb.com/diff/D63556283?dst_version_fbid=804905691596581&transaction_fbid=550949777494622 

This diff initializes inputFlatNoNulls_ as false.

Differential Revision: D63673714
    @facebook-github-bot
    Mingyu Zhang authored and facebook-github-bot committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    510858e View commit details
    Browse the repository at this point in the history