Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix velox_query_replayer linking error #11388

Closed
wants to merge 1 commit into from
Closed

Fix velox_query_replayer linking error #11388

wants to merge 1 commit into from

Conversation

zuyu
Copy link
Contributor

@zuyu zuyu commented Oct 30, 2024

A follow-up fix PR for #11360 to address the linking error:

[1432/1435] Linking CXX executable velox/tool/trace/velox_query_replayer
FAILED: velox/tool/trace/velox_query_replayer
...
Undefined symbols for architecture arm64:
  "facebook::velox::tool::trace::TraceReplayRunner::run()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::init()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::TraceReplayRunner()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "vtable for facebook::velox::tool::trace::TraceReplayRunner", referenced from:
      facebook::velox::tool::trace::TraceReplayRunner::~TraceReplayRunner() in TraceReplayerMain.cpp.o
   NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

ninja: build stopped: subcommand failed.
make[1]: *** [build] Error 1
make: *** [debug] Error 2

CC @xiaoxmeng

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 3fcf1ee
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/672253144dbf710008b2fe37

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 30, 2024
@majetideepak
Copy link
Collaborator

@kgpai can you please help merge this? Thanks.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Oct 30, 2024
@zuyu @facebook-github-bot
Fix velox_query_replayer linking error (#11388)
11e4a8e 
Summary:
A follow-up fix PR for #11360 to address the linking error:

```cmake
[1432/1435] Linking CXX executable velox/tool/trace/velox_query_replayer
FAILED: velox/tool/trace/velox_query_replayer
...
Undefined symbols for architecture arm64:
  "facebook::velox::tool::trace::TraceReplayRunner::run()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::init()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::TraceReplayRunner()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "vtable for facebook::velox::tool::trace::TraceReplayRunner", referenced from:

Reviewed By: xiaoxmeng

Differential Revision: D65217021

Pulled By: kgpai

fbshipit-source-id: 2e0e44d916a27853366d77d883f0add70993fdc0
@zuyu zuyu closed this Oct 31, 2024
@zuyu zuyu deleted the trace-linking branch October 31, 2024 03:44
@zuyu zuyu mentioned this pull request Nov 1, 2024
Closed
facebook-github-bot pushed a commit that referenced this pull request Nov 4, 2024
@zuyu @facebook-github-bot
Cleanup velox/tool/trace/CMakeLists.txt (#11406)
03a3173 
Summary:
A follow-up PR for #11351 to cleanup CMake.

`TraceReplayRunner.cpp` already added as a library in #11388.

CC duanmeng

Pull Request resolved: #11406

Reviewed By: Yuhta

Differential Revision: D65420171

Pulled By: mbasmanova

fbshipit-source-id: 4111bee7a238baa1bb87e885d100d35cdb569626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majetideepak majetideepak majetideepak approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuyu @majetideepak @facebook-github-bot