Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup velox/tool/trace/CMakeLists.txt #11406

Closed
wants to merge 1 commit into from
Closed

Cleanup velox/tool/trace/CMakeLists.txt #11406

wants to merge 1 commit into from

Conversation

zuyu
Copy link
Contributor

@zuyu zuyu commented Nov 1, 2024

A follow-up PR for #11351 to cleanup CMake.

TraceReplayRunner.cpp already added as a library in #11388.

CC @duanmeng

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 1, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d2ee63f
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6724f99a4f15ed0008149abd

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Nov 1, 2024
@duanmeng
Copy link
Collaborator

duanmeng commented Nov 2, 2024

@zuyu Thanks for your quick fix. FYI, it has been fixed in https://github.com/facebookincubator/velox/pull/11271/files#diff-2b08dc4c4a92bdae061f2ce887665243142bff0ea13bde12c80cc4e57fab8ac0L38

@duanmeng
Copy link
Collaborator

duanmeng commented Nov 2, 2024 •
edited
Loading

@zuyu Thanks for your quick fix. FYI, it has been fixed in https://github.com/facebookincubator/velox/pull/11271/files#diff-2b08dc4c4a92bdae061f2ce887665243142bff0ea13bde12c80cc4e57fab8ac0L38

@zuyu I will rebase and resolve the conflict if yours merged first.

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in 03a3173.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 03a31739.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@zuyu zuyu deleted the trace-cmake-cleanup branch November 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majetideepak majetideepak majetideepak approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zuyu @duanmeng @facebook-github-bot @majetideepak