Replace the overuse of StringView with std::string_view in Re2Function #8047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns.h/cpp Currently there are some overuse of StringView in Re2Functions.h/cpp. It's not good because StringView is not a replacement of std::string_view, its copy is expensive than std::string_view, its data() is not safe to point to for copied short StringView. In this PR we replace StringView with std::string_view if it is a field of struct or a function param which is not feed by XxxVector directly.
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
mbasmanova
reviewed
Dec 14, 2023
velox/functions/lib/Re2Functions.h
Outdated
| @@ -118,7 +118,7 @@ std::vector<std::shared_ptr<exec::FunctionSignature>> re2ExtractSignatures(); | |||
| /// characters} for patterns with wildcard characters only. Return | |||
| /// {kGenericPattern, 0} for generic patterns). | |||
| PatternMetadata determinePatternKind( | |||
| StringView pattern, | |||
| const std::string_view& pattern, | |||
There was a problem hiding this comment.
Pass std::string_view by value.
mbasmanova
reviewed
Dec 14, 2023
velox/functions/lib/Re2Functions.cpp
Outdated
| @@ -971,7 +967,7 @@ std::vector<std::shared_ptr<exec::FunctionSignature>> re2ExtractSignatures() { | |||
| } | |||
|
|
|||
| std::string unescape( | |||
| StringView pattern, | |||
| const std::string_view pattern, | |||
mbasmanova
approved these changes
Dec 14, 2023
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 2106478. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
Could this fuzzer error be related to this change? |
|
Never mind it's pre-existing issue: #7856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are some overuse of StringView in Re2Functions.h/cpp. It's not good because StringView is not a replacement of std::string_view, its copy is expensive than std::string_view, its data() is not safe to point to for copied short StringView.
In this PR we replace StringView with std::string_view if it is a field of struct or a function param which is not feed by XxxVector directly.