Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the overuse of StringView with std::string_view in Re2Function #8047

Closed
wants to merge 3 commits into from
Closed

Replace the overuse of StringView with std::string_view in Re2Function #8047

wants to merge 3 commits into from

Commits on Dec 14, 2023

  1. Replace the overuse of StringView with std::string_view in Re2Functio… 

    …ns.h/cpp

Currently there are some overuse of StringView in Re2Functions.h/cpp. It's not
good because StringView is not a replacement of std::string_view, its copy is
expensive than std::string_view, its data() is not safe to point to for copied
short StringView.

In this PR we replace StringView with std::string_view if it is a field of struct
or a function param which is not feed by XxxVector directly.
    @xumingming
    xumingming committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5566124 View commit details
    Browse the repository at this point in the history

  2. Pass std::string_view by value

    @xumingming
    xumingming committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c905def View commit details
    Browse the repository at this point in the history

  3. Drop const from std::string_view

    @xumingming
    xumingming committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    491a0a8 View commit details
    Browse the repository at this point in the history