Merge pull request #25 from ruanchaves/master

[Fix] Bug fix in PARAMETERS at run_benchmark.py and kwargs in _load_candidate() at main_dense.py
facebookresearch · Jul 12, 2020 · e919933 · e919933
2 parents b3e5b11 + 1642d5c
commit e919933
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/blink/main_dense.py b/blink/main_dense.py
@@ -312,7 +312,7 @@ def load_models(args, logger=None):
         wikipedia_id2local_id,
         faiss_indexer,
     ) = _load_candidates(
-        args.entity_catalogue, args.entity_encoding, args.faiss_index, args.index_path,
+        args.entity_catalogue, args.entity_encoding, faiss_index=args.faiss_index, index_path=args.index_path,
     )
 
     return (

diff --git a/blink/run_benchmark.py b/blink/run_benchmark.py
@@ -27,6 +27,8 @@
 ]
 
 PARAMETERS = {
+    "faiss_index": None,
+    "index_path": None,
     "test_entities": None,
     "test_mentions": None,
     "interactive": False,
@@ -38,6 +40,7 @@
     "crossencoder_config": "models/crossencoder_wiki_large.json",
     "output_path": "output",
     "fast": False,
+    "top_k": 100,
 }
 args = argparse.Namespace(**PARAMETERS)