Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

[Fix] Bug fix in PARAMETERS at run_benchmark.py and kwargs in _load_candidate() at main_dense.py #25

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

ruanchaves
Copy link
Contributor

Some commands for running the benchmark are given on the README:

./scripts/get_train_and_benchmark_data.sh
python scripts/create_BLINK_benchmark_data.py
python blink/run_benchmark.py

The command python blink/run_benchmark.py won't work on the current version of this repository unless the changes suggested in this pull request are made.

@facebook-github-bot
Copy link

Hi @ruanchaves!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ruanchaves
Copy link
Contributor Author

I have signed the CLA but the bot is still sending me this message. I'll mail them.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2020
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fabiopetroni
Copy link
Contributor

thanks a lot @ruanchaves ! :)

@fabiopetroni fabiopetroni merged commit e919933 into facebookresearch:master Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants