Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add support for faiss-gpu on Windows #1610

Closed
wants to merge 9 commits into from
Closed

[WIP] Add support for faiss-gpu on Windows #1610

wants to merge 9 commits into from

Conversation

beauby
Copy link
Contributor

@beauby beauby commented Jan 7, 2021

No description provided.

@beauby beauby force-pushed the windows-gpu branch 9 times, most recently from df65258 to 82fbc47 Compare January 7, 2021 19:16
@beauby beauby marked this pull request as draft January 7, 2021 22:21
@h-vetinari
Copy link
Contributor

h-vetinari commented Jan 9, 2021 •
edited
Loading

This PR will close #1586 :)

@h-vetinari h-vetinari mentioned this pull request Jan 9, 2021
Closed
@h-vetinari
Copy link
Contributor

Hey @beauby, I used your commit d2c04d0 in and came up with two additional ones (for which I opened #1614) in conda-forge/faiss-split-feedstock#19.

I realize that the build infra here is a bit different than on conda-forge, but with that, I got pretty far in the build now. Added two more patches based on the errors that showed up, let's see how it goes.

@beauby beauby force-pushed the windows-gpu branch 8 times, most recently from 030022e to 956e35f Compare January 11, 2021 04:55
@beauby beauby force-pushed the windows-gpu branch 2 times, most recently from 2671e14 to 42b84cb Compare January 11, 2021 05:28
facebook-github-bot pushed a commit that referenced this pull request Jan 11, 2021
@h-vetinari @facebook-github-bot
Some fixes for building on windows + cuda (#1614)
3d3d539 
Summary:
Upstreaming some work towards #1586 from conda-forge/faiss-split-feedstock#19; complements #1610

Pull Request resolved: #1614

Reviewed By: mdouze

Differential Revision: D25864994

Pulled By: wickedfoo

fbshipit-source-id: 4abaaebf1c4102c24c3a9dca544744318e780581
@beauby beauby force-pushed the windows-gpu branch 9 times, most recently from c6c81bd to 68aa240 Compare January 11, 2021 17:00
@h-vetinari h-vetinari mentioned this pull request Jan 29, 2021
Closed
@h-vetinari h-vetinari mentioned this pull request Feb 18, 2021
Closed
4 tasks
@facebook-github-bot
Copy link
Contributor

Hi @beauby!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@beauby beauby closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beauby @h-vetinari @facebook-github-bot