Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] - remove pyrobot integration #2015

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[BE] - remove pyrobot integration #2015

merged 1 commit into from
Aug 20, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 19, 2024

Motivation and Context

This PR removes the pyrobot integration from early pointnav sim-2-real. Pyrobot project is largely inactive and more recent sim2real efforts have developed alternative integration code.

How Has This Been Tested

CI

Types of changes

  • [Docs change] Addition or changes to the documentation
  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 19, 2024
0mdc
0mdc approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@aclegg3 aclegg3 merged commit c93398c into main Aug 20, 2024
4 checks passed
@aclegg3 aclegg3 deleted the alex-08_19-remove_pyrobot_integration branch August 20, 2024 15:19
@aclegg3 aclegg3 mentioned this pull request Nov 18, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@akshararai akshararai Awaiting requested review from akshararai

@xavierpuigf xavierpuigf Awaiting requested review from xavierpuigf

@danieltmeta danieltmeta Awaiting requested review from danieltmeta

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @0mdc @facebook-github-bot