Partially refactor JS utilities to support future webapps in separate folder structure #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ldcWV
changed the title
eundersander
reviewed
Jul 1, 2021
added 3 commits
July 6, 2021 15:12
eundersander
previously approved these changes
Jul 7, 2021
eundersander
reviewed
Jul 7, 2021
| @@ -0,0 +1,80 @@ | |||
| // Copyright (c) Facebook, Inc. and its affiliates. | |||
There was a problem hiding this comment.
Is there any code redundancy between this file and the existing vr_demo.js?
There was a problem hiding this comment.
Yeah, see here: #1364 (comment)
The existing vr_demo.js will be deleted in #1366, so this redundancy will be resolved as soon as that PR gets merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
vr_utils.jshas been added tosrc/esp/bindings_js/modules. This is a new file that contains functions that help with setting up the eye sensors and updating the sensor locations based on the user's pose.Changes were also made to
utils.jsso that it no longer needs to importinfoSemanticFileNamefromdefaults.js. This allows it to be independently included as a module in webapps.How Has This Been Tested
The WebXR Hand Demo port to the new folder structure (#1366) which uses these utils functions was launched and ran successfully.
Types of changes
Checklist