-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReplicaCAD v1.3 #1681
ReplicaCAD v1.3 #1681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested it. Testing with C++ and python viewer works perfectly. Testing with ReplicaCAD_quickstart.py results in an all-black screen recording. Log attached. |
The issue is that the scene is specified as the NONE scene. This seems to be due to the fact that the ReplicaCAD_quickstart is built such that it is more colab-friendly than python friendly - it relies on the user to select a scene from the available scene dropdown cell, before the cell that launches sim and displays the scene is launched. Edit : @dhruvbatra I addressed this issue in this PR ..Or @aclegg3 could fix it in this PR 😺 |
We'll merge your fix and then rebase this PR on main. 👍 |
Pulled. Re-tested. Does this video look sensible? I can't imagine where the agent has been spawned. ReplicaCAD_scene_view.mp4 |
With the new NavMeshes, the closet behind the closed door is cutoff from the rest of the scene by default for the fully dynamic spaces (apt_#). With the default seed, the agent spawns inside the closet for apt_0. 😆 Edit: we could choose apt_1 for the default, change the seed, or modify the scenes to include the closet in the primary navmesh component (ignoring the door). Happy to pursue any of these options. |
Thanks.
Modifying scenes sounds like an overkill. Either apt_1 or changing seed will work, whichever is easier. |
Update 03/07: added missing sofa receptacle annotations. |
Motivation and Context
Updates the default downloader version for ReplicaCAD to v1.3.
Changes with v1.3:
How Has This Been Tested
Locally
Types of changes
Checklist