Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplicaCAD v1.3 #1681

Merged
merged 4 commits into from
Mar 3, 2022
Merged

ReplicaCAD v1.3 #1681

merged 4 commits into from
Mar 3, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Mar 2, 2022

Motivation and Context

Updates the default downloader version for ReplicaCAD to v1.3.

Changes with v1.3:

  • Updated synthetic 105 variations with baked stage, geometry consistent with baked scenes.
  • New NavMesh files for all scenes including STATIC and articulated (URDF) furniture.
  • Added inner surface to objects/frl_apartment_kitchen_utensil.glb to fix interior culling.
  • Added Receptacle annotation to most articulated furniture to support rearrangement tasks.
  • Added global furniture receptacle annotations to baked scenes.
  • Updated fridge interior for consistency b/t synthetic and baked scenes.
  • Added collision group tags to articulated furniture for better performance when initialized as STATIC with fixed_base.
    • Added dynamic variants of URDFs for non-static use cases.
  • All modified scene configs such that articulated objects have automatically enforced joint limits by default.
  • Added "settled" states for dynamics scenes (i.e., apt_0...5) to reduce object movement (e.g. dropping onto surfaces) upon scene initialization.
  • Adjusted all 105 variation layouts to reduce object inter-penetration artifacts.
  • Additional minor fixes and modifications
  • Added sofa receptacle (03/07)

How Has This Been Tested

Locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 2, 2022
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvbatra
Copy link
Contributor

I tested it.

Testing with C++ and python viewer works perfectly. Testing with ReplicaCAD_quickstart.py results in an all-black screen recording. Log attached.
log.txt

@jturner65
Copy link
Contributor

jturner65 commented Mar 3, 2022

I tested it.

Testing with C++ and python viewer works perfectly. Testing with ReplicaCAD_quickstart.py results in an all-black screen recording. Log attached. log.txt

The issue is that the scene is specified as the NONE scene. This seems to be due to the fact that the ReplicaCAD_quickstart is built such that it is more colab-friendly than python friendly - it relies on the user to select a scene from the available scene dropdown cell, before the cell that launches sim and displays the scene is launched.

Edit : @dhruvbatra I addressed this issue in this PR

..Or @aclegg3 could fix it in this PR 😺

@aclegg3
Copy link
Contributor Author

aclegg3 commented Mar 3, 2022

Edit : @dhruvbatra I addressed this issue in this PR

..Or @aclegg3 could fix it in this PR 😺

We'll merge your fix and then rebase this PR on main. 👍

@dhruvbatra
Copy link
Contributor

Pulled. Re-tested. Does this video look sensible? I can't imagine where the agent has been spawned.

ReplicaCAD_scene_view.mp4

@aclegg3
Copy link
Contributor Author

aclegg3 commented Mar 3, 2022

Pulled. Re-tested. Does this video look sensible? I can't imagine where the agent has been spawned.

With the new NavMeshes, the closet behind the closed door is cutoff from the rest of the scene by default for the fully dynamic spaces (apt_#). With the default seed, the agent spawns inside the closet for apt_0. 😆

Edit: we could choose apt_1 for the default, change the seed, or modify the scenes to include the closet in the primary navmesh component (ignoring the door). Happy to pursue any of these options.

@aclegg3 aclegg3 merged commit db81ed8 into main Mar 3, 2022
@aclegg3 aclegg3 deleted the replica-cad-v1.3 branch March 3, 2022 19:35
@dhruvbatra
Copy link
Contributor

Thanks.

we could choose apt_1 for the default, change the seed, or modify the scenes to include the closet in the primary navmesh component (ignoring the door).

Modifying scenes sounds like an overkill. Either apt_1 or changing seed will work, whichever is easier.

@aclegg3
Copy link
Contributor Author

aclegg3 commented Mar 8, 2022

Update 03/07: added missing sofa receptacle annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants