Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVP Batch renderer WIP #1745

Closed
wants to merge 5 commits into from
Closed

MVP Batch renderer WIP #1745

wants to merge 5 commits into from

Conversation

eundersander
Copy link
Contributor

See corresponding Hab-lab PR for details: facebookresearch/habitat-lab#863

How Has This Been Tested

See src/tests/ReplayBatchRendererTest.cpp.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 4, 2022
@eundersander eundersander added the do not merge Not ready to merge. This label should block merging. label May 4, 2022
@eundersander eundersander mentioned this pull request May 4, 2022
Closed
7 tasks
@mosra mosra mentioned this pull request Jun 30, 2022
Merged
@0mdc 0mdc self-assigned this Oct 5, 2022
@0mdc 0mdc mentioned this pull request Oct 19, 2022
Merged
11 tasks
@0mdc
Copy link
Contributor

0mdc commented Oct 24, 2022

Closing - These changes are brought in here: #1904

@0mdc 0mdc closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0mdc 0mdc

Labels
CLA Signed Do not delete this pull request or issue due to inactivity. do not merge Not ready to merge. This label should block merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eundersander @0mdc @facebook-github-bot