Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pybind11 to v2.10.0 #1815

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Update pybind11 to v2.10.0 #1815

merged 4 commits into from
Jul 26, 2022

Conversation

Skylion007
Copy link
Contributor

@Skylion007 Skylion007 commented Jul 16, 2022

Motivation and Context

  • This PR updates pybind11 to the latest version which should allow habitat-sim to build on 3.11 beta, adds a bunch of speed and correctness fixes, and optimize pybind11 exception handling significantly, especially for large Python stack traces. This update should improve performance, build speed, and overall correctness of the Python bindings.
  • I've also optimized the speed of handling of attributes, function casting, and other aspects of pybind11 in this PR which should hopefully further reduce overhead.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 16, 2022
@Skylion007
Copy link
Contributor Author

Skylion007 commented Jul 17, 2022

@jturner65 FYI, looks like this pybind11 update removed a transitive include that caused a bug to appear caused by shadowing of ESP allocator with std::allocator. Either that or some minor update in the container caught this bug. Very odd edge case.
Fixed in another PR

@Skylion007 Skylion007 requested a review from mosra July 20, 2022 18:25
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Skylion007! Great to migrate your pybind work back into Habitat.

@Skylion007 Skylion007 merged commit d1cf201 into main Jul 26, 2022
@Skylion007 Skylion007 deleted the skylion007/pybind11_v2100 branch July 26, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants