Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize src/esp by removing temporaries #1835

Merged
merged 3 commits into from
Aug 24, 2022
Merged

chore: optimize src/esp by removing temporaries #1835

merged 3 commits into from
Aug 24, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • This is a minor optimization PR that removes some useless temporaries found through static analysis.

How Has This Been Tested

  • Locally and through CI

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 23, 2022
@Skylion007 Skylion007 changed the title Skylion007/modernize use emplace 2 chore: optimize src/esp by removing temporaries Aug 23, 2022
mosra
mosra approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 👍

@Skylion007 Skylion007 merged commit 172a94c into main Aug 24, 2022
@Skylion007 Skylion007 deleted the skylion007/modernize-use-emplace-2 branch August 24, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@mosra mosra mosra approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skylion007 @mosra @aclegg3 @facebook-github-bot