Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] - fix nightly conda preserve_egg_dir #1844

Merged
merged 2 commits into from
Aug 31, 2022
Merged

[CI] - fix nightly conda preserve_egg_dir #1844

merged 2 commits into from
Aug 31, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 29, 2022

Motivation and Context

Nightly conda failing due to conflicting files during merge. Implement suggested change setting preserve_egg_dir = True seems to fix it.

How Has This Been Tested

Built and uploaded nightly CI from this PR branch.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2022
@aclegg3 aclegg3 requested a review from mathfac August 30, 2022 16:13
mathfac
mathfac approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing this.

@aclegg3 aclegg3 merged commit adea318 into main Aug 31, 2022
@aclegg3 aclegg3 deleted the test-nightly-conda-preserve_egg_dir branch August 31, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathfac mathfac mathfac approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @mathfac @facebook-github-bot