Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] minor fix to viewer text string creation for semantic labels #1859

Merged
merged 1 commit into from
Sep 8, 2022
Merged

[bugfix] minor fix to viewer text string creation for semantic labels #1859

merged 1 commit into from
Sep 8, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Sep 8, 2022

Motivation and Context

#1853 converted viewer.cpp to use Magnum text instead of imgui. Syntax for referencing variables in strings changed and one refactor was missed.

How Has This Been Tested

locally with viewer.cpp

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from mosra September 8, 2022 18:10
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 8, 2022
@aclegg3 aclegg3 merged commit 8d32a3c into main Sep 8, 2022
@aclegg3 aclegg3 deleted the viewer-test-fix branch September 8, 2022 18:34
@mosra
Copy link
Collaborator

mosra commented Sep 8, 2022

Dang, I knew I missed something 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mosra mosra Awaiting requested review from mosra

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclegg3 @mosra @Skylion007 @facebook-github-bot