Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python - Add settings module to utils init #1879

Merged
merged 1 commit into from
Sep 29, 2022
Merged

python - Add settings module to utils init #1879

merged 1 commit into from
Sep 29, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Sep 29, 2022

Motivation and Context

When importing from outside of habitat-sim, settings module was not available from utils.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 29, 2022
@aclegg3 aclegg3 merged commit fb5d1a9 into main Sep 29, 2022
@aclegg3 aclegg3 deleted the add-settings-to-init branch September 29, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrreyna jrreyna jrreyna approved these changes

@jaraujo98 jaraujo98 jaraujo98 approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@ykarmesh ykarmesh Awaiting requested review from ykarmesh

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aclegg3 @Skylion007 @jaraujo98 @jrreyna @facebook-github-bot