Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spot download #1885

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Add Spot download #1885

merged 1 commit into from
Oct 5, 2022

Conversation

jimmytyyang
Copy link
Contributor

Motivation and Context

Given new examples using Spot robot in habitat lab, the download utility was updated to include the source for the Spot URDF model

How Has This Been Tested

Downloaded the dataset

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 3, 2022
@jimmytyyang jimmytyyang marked this pull request as ready for review October 3, 2022 19:46
aclegg3
aclegg3 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jimmytyyang. Looks good to me. 👍

@jimmytyyang jimmytyyang merged commit 58921de into main Oct 5, 2022
aclegg3 pushed a commit that referenced this pull request Oct 6, 2022
@jimmytyyang @aclegg3
Add Spot download (#1885)
e8a1314
@jturner65 jturner65 deleted the spot branch November 29, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmytyyang @aclegg3 @facebook-github-bot