Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data downloader for hm3d v0.2 #1910

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Update data downloader for hm3d v0.2 #1910

merged 2 commits into from
Oct 26, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Oct 24, 2022

Motivation and Context

v0.2 is released, the downloader should get this version.

Note: changed downloader version from 1.0 to 0.2. Appears to downgrade, but this should have been 0.1 to begin with.

How Has This Been Tested

Should be tested.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 24, 2022
@aclegg3 aclegg3 mentioned this pull request Oct 24, 2022
Closed
@ykarmesh
Copy link
Contributor

Do you plan to test this?

@devendrachaplot
Copy link

Looks good to me.

@aclegg3
Copy link
Contributor Author

aclegg3 commented Oct 26, 2022

Do you plan to test this?

Just tested this, seems to work as expected. 👍

@aclegg3 aclegg3 merged commit 0b0fb04 into main Oct 26, 2022
@aclegg3 aclegg3 deleted the hm3d-v0.2 branch October 26, 2022 00:42
This was referenced Oct 26, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykarmesh ykarmesh ykarmesh approved these changes

@devendrachaplot devendrachaplot Awaiting requested review from devendrachaplot

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclegg3 @ykarmesh @devendrachaplot @facebook-github-bot