Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted fixes for more robust handling of asset corner cases #1915

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Assorted fixes for more robust handling of asset corner cases #1915

merged 4 commits into from
Oct 26, 2022

Commits on Oct 26, 2022

  1. Enable shader texture transform only if it's actually textured. 

    If it's not (for example if a texture failed to load or if the
material data are strange in some way), then the shader construction
would assert with

    Shaders::PhongGL: texture transformation enabled but the shader is not textured

This change *doesn't* fix any root causes of a texture missing or
failing to load, it only makes it not abort anymore.
    @mosra
    mosra committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c84420c View commit details
    Browse the repository at this point in the history

  2. Don't crash if BasisImporter isn't present.

    @mosra
    mosra committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    683fd45 View commit details
    Browse the repository at this point in the history

  3. Don't treat files with no default scene as having no scenes at all. 

    Magnum's GltfImporter used to return 0 if the default scene field wasn't
present, but now it returns -1 to indicate no default scene is
specified, consistently with all other importers. The code mistakenly
relied on the previous behavior.
    @mosra
    mosra committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b3bb99f View commit details
    Browse the repository at this point in the history

  4. Stupid clang format, this makes the code LESS readable, not more.

    @mosra
    mosra committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    8b033b7 View commit details
    Browse the repository at this point in the history