Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(perf): Improve codebase by adding std::move on last use of object #1930

Merged
merged 3 commits into from
Nov 3, 2022
Merged

(perf): Improve codebase by adding std::move on last use of object #1930

merged 3 commits into from
Nov 3, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • I found a new clang-tidy check in that is being proposed and decided to give it an early try. I went through all the fixes manually and removed any false positives. This should get rid of of most of the unnecessary copies left in the codebase.

How Has This Been Tested

  • Locally and with Clang-Tidy

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 3, 2022
0mdc
0mdc approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Skylion007 Skylion007 merged commit 4403ed4 into main Nov 3, 2022
@Skylion007 Skylion007 deleted the clang-tidy-move-analysis-fixes branch November 3, 2022 17:59
jrreyna pushed a commit that referenced this pull request Nov 4, 2022
@Skylion007 @jrreyna
(perf): Improve codebase by adding std::move on last use of object (#…
2e9fe07 
…1930)

* (perf): Improve codebase by adding std::move on last use of object

* Fix missing one

* A couple of manual std::move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @0mdc @facebook-github-bot