Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] - utils.settings.py #1949

Merged
merged 1 commit into from
Nov 28, 2022
Merged

[docs] - utils.settings.py #1949

merged 1 commit into from
Nov 28, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Nov 24, 2022

Motivation and Context

Added some documentation for settings utility module.

How Has This Been Tested

Local rendering:
image

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 24, 2022
mathfac
mathfac approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More docs are always great!

jaraujo98
jaraujo98 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@jaraujo98 jaraujo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, Alex!

@aclegg3 aclegg3 merged commit d830227 into main Nov 28, 2022
@aclegg3 aclegg3 deleted the settings-docs branch November 28, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@jaraujo98 jaraujo98 jaraujo98 approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@mathfac mathfac mathfac approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aclegg3 @mathfac @Skylion007 @jaraujo98 @0mdc @facebook-github-bot