Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] - skip non-triangle mesh primitives in mesh join for navmesh recomputation #1951

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Nov 28, 2022

Motivation and Context

@mosra fixed a bug with non-triangle primitive support in #1888. This worked for physics, but was not being applied to navmesh recomputation resulting in artifacts for affected scenes. See comments for details.

How Has This Been Tested

Locally with FP scene 102816627.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from mosra November 28, 2022 23:53
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 28, 2022
@aclegg3 aclegg3 merged commit 224f99c into main Nov 29, 2022
@aclegg3 aclegg3 deleted the join-mesh-skip-non-triangles branch November 29, 2022 16:46
@mukulkhanna
Copy link
Contributor

mukulkhanna commented Nov 29, 2022

Thanks Alex! Yes, this seems to be working. Here's a before (without the above commit) and after (with the above commit) of a sample scene's topdown map:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants