Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a link to the github Discussions page on README #1955

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Add a link to the github Discussions page on README #1955

merged 2 commits into from
Dec 2, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Dec 1, 2022

Motivation and Context

We are directing all habitat-sim and habitat-lab users to the habitat-lab Discussions forum.

How Has This Been Tested

Types of changes

  • [x ] Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 1, 2022
@aclegg3
Copy link
Contributor Author

aclegg3 commented Dec 1, 2022

Open to alternative suggestions for placement. Aiming for something prominent and early in the README.

dhruvbatra
dhruvbatra reviewed Dec 2, 2022
View reviewed changes
README.md Show resolved Hide resolved
@aclegg3 aclegg3 merged commit 3e50086 into main Dec 2, 2022
@aclegg3 aclegg3 deleted the link-to-discussions branch December 2, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvbatra dhruvbatra dhruvbatra left review comments

@Skylion007 Skylion007 Skylion007 approved these changes

@mathfac mathfac Awaiting requested review from mathfac

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclegg3 @Skylion007 @dhruvbatra @facebook-github-bot