Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receptacle test assets #1994

Merged
merged 8 commits into from
Mar 14, 2023
Merged

Receptacle test assets #1994

merged 8 commits into from
Mar 14, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jan 31, 2023

Motivation and Context

Added testing assets with Receptacle metadata definitions.
See Habitat-lab PR 1042 for details.

How Has This Been Tested

In viewer:
image

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 31, 2023
This was referenced Feb 1, 2023
Merged
Closed
jturner65
jturner65 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aclegg3 aclegg3 merged commit 25450ab into main Mar 14, 2023
@aclegg3 aclegg3 deleted the receptacle-test-assets branch March 14, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @jturner65 @facebook-github-bot